added some rsa-pss tests and bug fixes in test/#302
Closed
sebastian-carpenter wants to merge 1 commit into
Closed
Conversation
Contributor
|
Reworked into #308 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the two tests I added are broken. The failures are on wolfProviders side though not ossl.
It looks like RSA-PSS salting is broken with RSA_PSS_SALTLEN_AUTO and RSA_PSS_SALTLEN_AUTO_DIGEST_MAX as the length.
Additionally, in the restrictions test wolfProvider fails to get past
EVP_DigestSignInit_exbut openssl does. However, wolfProvider succeeds at doing this in various functions in test_pkey.c so there's something I did in test_rsa_pss_restrictions that makes it stop working. It is probably related to keygen.